-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache ~/.m2/ to speed up GH actions #1109
Conversation
33943b4
to
ab1ca90
Compare
.github/workflows/native-image.yaml
Outdated
!~/.m2/repository/org/eclipse/lemminx | ||
key: ${{ runner.os }}-${{ hashFiles('**/pom.xml') }} | ||
restore-keys: | | ||
${{ runner.os }}-node |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious about this value. Looking at https://docs.github.com/en/actions/guides/caching-dependencies-to-speed-up-workflows#matching-a-cache-key, this would match any cache key starting with ${{ runner.os }}-node and the most recent if there are multiple , but there aren't any that contain the "node" in the key declaration. Is it some pre-defined key somewhere else ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fbricon , I think this should just be ${{ runner.os }}-
according to the docs. Let me know if that makes sense. I wouldn't mind trying this out on on JDT-LS as well.
as per https://github.com/actions/cache/blob/main/examples.md#java---maven, it should actually be |
That's fine. So the key should be |
Actually, we should split the cache in 2, for Maven and Graalvm, but I don't know what to use for graalvm restore key |
b94956b
to
9bf07ba
Compare
Signed-off-by: Fred Bricon <fbricon@gmail.com>
9bf07ba
to
b3a3897
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me. We can hopefully take a similar approach in JDT-LS.
No description provided.