Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved accuracy of attribute value quick fix suggestions #1136

Merged
merged 1 commit into from
Dec 13, 2021
Merged

Improved accuracy of attribute value quick fix suggestions #1136

merged 1 commit into from
Dec 13, 2021

Conversation

AlexXuChen
Copy link
Contributor

Improved accuracy of attribute value Quick Fix suggestions.

Fixes redhat-developer/vscode-xml/issues/618

Signed-off-by: Alexander Chen alchen@redhat.com

@AlexXuChen AlexXuChen force-pushed the issue618-xml branch 2 times, most recently from b6240ae to 45cfcf9 Compare December 10, 2021 17:56
rgrunber
rgrunber approved these changes Dec 11, 2021
View reviewed changes
Copy link
Contributor

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works as expected. I don't see any similar tests for code actions, so I guess this should be fine.

@angelozerr , let me know if this can be merged.

...ipse/lemminx/extensions/contentmodel/participants/codeactions/cvc_attribute_3CodeAction.java Outdated Show resolved Hide resolved
@AlexXuChen AlexXuChen marked this pull request as ready for review December 11, 2021 03:26
@mengineerchen mengineerchen mentioned this pull request Dec 11, 2021
Closed
@rgrunber rgrunber mentioned this pull request Dec 13, 2021
Merged
@angelozerr
Copy link
Contributor

It should be nice to write tests for this feature. We have already test for similar with local name at https://github.com/eclipse/lemminx/blob/e41b18cfc6541109907d6a035da2972b34b5ca6c/org.eclipse.lemminx/src/test/java/org/eclipse/lemminx/extensions/contentmodel/XMLSchemaDiagnosticsTest.java#L556

I suggest you write a test with similar for attribute (see tests which defines attribute enumeration by searching cvc_attribute_3 in https://github.com/eclipse/lemminx/blob/master/org.eclipse.lemminx/src/test/java/org/eclipse/lemminx/extensions/contentmodel/XMLSchemaDiagnosticsTest.java

Improved accuracy of attribute value quick fix suggestions
3fe24bf 
Signed-off-by: Alexander Chen <alchen@redhat.com>
@angelozerr angelozerr merged commit d70604b into eclipse-lemminx:master Dec 13, 2021
@angelozerr
Copy link
Contributor

Thanks @AlexXuChen !

@AlexXuChen AlexXuChen deleted the issue618-xml branch December 13, 2021 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgrunber rgrunber rgrunber approved these changes

@angelozerr angelozerr Awaiting requested review from angelozerr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve xsd-based quick-fix suggestions
3 participants
@AlexXuChen @angelozerr @rgrunber