Add XMLDownloadExternalResourcesSettings for native. #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: azerr <azerr@redhat.com>
rgrunber
approved these changes
Feb 1, 2022
There was a problem hiding this comment.
Given that I saw :
[Warn - 11:00:10 AM] Feb 01, 2022 11:00:10 org.eclipse.lemminx.settings.FaultTolerantTypeAdapterFactory$1 read()
Message: Encountered an invalid setting. Using the default value. Please check your settings for outdated or invalid settings.
java.lang.RuntimeException: Unable to invoke no-args constructor for class org.eclipse.lemminx.extensions.contentmodel.settings.XMLDownloadExternalResourcesSettings. Registering an InstanceCreator with Gson for this type may fix this problem.
this is likely the solution, but I'll confirm for myself as well. I think we can merge for now though.
|
Thanks Angelo. I confirm this solves the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add XMLDownloadExternalResourcesSettings for native.
Signed-off-by: azerr azerr@redhat.com