DOCTYPE entities interfering with hover annotation display of tags / attributes #1212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to write test but it should fix the issue redhat-developer/vscode-xml#716. The problem with this issue is when XSD is bound with file association and there are DTD internal, it loose the file association link. The PR should fix that and fixes too:
|
angelozerr
force-pushed
the
internal-dtd-fileassociation-both
branch
2 times, most recently
from
3e580dc to
affc82a
Compare
angelozerr
force-pushed
the
internal-dtd-fileassociation-both
branch
from
affc82a to
c6225f7
Compare
attributes. Fixes redhat-developer/vscode-xml#716 Signed-off-by: azerr <azerr@redhat.com>
|
Tests are written now.Thanks @AlexXuChen for your review. |
angelozerr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOCTYPE entities interfering with hover annotation display of tags / attributes.
Fixes redhat-developer/vscode-xml#716
Signed-off-by: azerr azerr@redhat.com