Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit no-arg constructor for ConfigurationItemEdit. #1412

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

rgrunber
Copy link
Contributor

Signed-off-by: Roland Grunberg rgrunber@redhat.com

@rgrunber rgrunber force-pushed the no-arg-config-item-edit branch from 1e29a48 to 1507ba6 Compare December 15, 2022 19:13
@datho7561 datho7561 self-requested a review December 15, 2022 19:27
Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
@rgrunber rgrunber force-pushed the no-arg-config-item-edit branch from 1507ba6 to 001d5cc Compare December 15, 2022 19:36
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks, Roland!

@datho7561 datho7561 added this to the 0.23.2 milestone Dec 15, 2022
@datho7561 datho7561 added the bug Something isn't working label Dec 15, 2022
@datho7561 datho7561 merged commit 5873946 into eclipse-lemminx:main Dec 15, 2022
@rgrunber rgrunber deleted the no-arg-config-item-edit branch December 15, 2022 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants