Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextDocument to expose an API for getting a document line number by offset #1519

Closed
vrubezhny opened this issue May 18, 2023 · 0 comments · Fixed by #1520
Closed

TextDocument to expose an API for getting a document line number by offset #1519

vrubezhny opened this issue May 18, 2023 · 0 comments · Fixed by #1520
Milestone
0.26.0

Comments

@vrubezhny
Copy link
Contributor

The TextDocument class provides a getter for obtaining a line delimiter for a line number:

org.eclipse.lemminx.commons.TextDocument.lineDelimiter(int)

... but there is no way to get the number of line by offset.

I'd like the TextDocument class to expose an API method similar to org.eclipse.lemminx.commons.ILineTracker.getLineNumberOfOffset(int) to make it possible to be used by clients.
vrubezhny added a commit to vrubezhny/lemminx that referenced this issue May 18, 2023
@vrubezhny
TextDocument to expose an API for getting a document line number by o…
fbfcbb7 
…ffset eclipse-lemminx#1519
@vrubezhny vrubezhny mentioned this issue May 18, 2023
Merged
@vrubezhny vrubezhny linked a pull request May 18, 2023 that will close this issue
TextDocument to expose an API for getting a document line number by o… #1520
Merged
vrubezhny added a commit to vrubezhny/lemminx that referenced this issue May 18, 2023
@vrubezhny
TextDocument to expose an API for getting a document line number by o…
af6546e 
…ffset eclipse-lemminx#1519
angelozerr pushed a commit that referenced this issue May 18, 2023
@vrubezhny @angelozerr
TextDocument to expose an API for getting a document line number by o…
7c2c591 
…ffset #1519
@angelozerr angelozerr added this to the 1.0.0 milestone Jun 13, 2023
@vrubezhny vrubezhny modified the milestones: 1.0.0, 0.26.0 Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.26.0
Development

Successfully merging a pull request may close this issue.

TextDocument to expose an API for getting a document line number by o… vrubezhny/lemminx
2 participants
@vrubezhny @angelozerr