CodeAction for missing root end tag #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikolasKomonen
changed the title
NikolasKomonen
force-pushed
the
missingRootTagCodeAction
branch
from
6bca0c1 to
e026c08
Compare
angelozerr
reviewed
Nov 16, 2019
...lsp4xml/extensions/contentmodel/participants/codeactions/MarkupEntityMismatchCodeAction.java
Show resolved
Hide resolved
angelozerr
reviewed
Nov 16, 2019
...lsp4xml/extensions/contentmodel/participants/codeactions/MarkupEntityMismatchCodeAction.java
Outdated
Show resolved
Hide resolved
angelozerr
reviewed
Nov 16, 2019
...lsp4xml/extensions/contentmodel/participants/codeactions/MarkupEntityMismatchCodeAction.java
Outdated
Show resolved
Hide resolved
angelozerr
reviewed
Nov 16, 2019
...lsp4xml/extensions/contentmodel/participants/codeactions/MarkupEntityMismatchCodeAction.java
Outdated
Show resolved
Hide resolved
|
@NikolasKomonen I think we should manage <a>but it doesn't work when a is not a root element: <root>
<a>
</root>because in this case it's a |
NikolasKomonen
force-pushed
the
missingRootTagCodeAction
branch
from
e026c08 to
e7aa564
Compare
|
@angelozerr I've updated to also work for ETagRequired, let me know if anything else needs to be updated |
angelozerr
reviewed
Nov 22, 2019
...eclipse/lsp4xml/extensions/contentmodel/participants/codeactions/ETagRequiredCodeAction.java
Show resolved
Hide resolved
angelozerr
reviewed
Nov 22, 2019
...lsp4xml/extensions/contentmodel/participants/codeactions/MarkupEntityMismatchCodeAction.java
Outdated
Show resolved
Hide resolved
|
@NikolasKomonen please fix my 2 little comments and after that we can merge it. |
Creates a code action for both MarkupEntityMismatch and ETagRequired errors Fixes eclipse-lemminx#588 Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
NikolasKomonen
force-pushed
the
missingRootTagCodeAction
branch
from
e7aa564 to
b69f2e1
Compare
|
@angelozerr Hey, I've update the last 2 things. It should be good to go now. |
|
Nice work @NikolasKomonen , thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #588
Signed-off-by: Nikolas Komonen nikolaskomonen@gmail.com