Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future of experimental leshan-server-cluster module #679

Closed
sbernard31 opened this issue Apr 9, 2019 · 7 comments
Closed

Future of experimental leshan-server-cluster module #679

sbernard31 opened this issue Apr 9, 2019 · 7 comments
Labels
discussion Discussion about anything

Comments

@sbernard31
Copy link
Contributor

sbernard31 commented Apr 9, 2019

We hope we will be able to release a 1.0.0 version of Leshan during this summer.

The state of leshan-server-cluster is clearly not in an acceptable state for a 1.0.0 release... So it will not be part of the release !

It seems to us that the better option is to create a new leshan-server-redis project which could include Redis store implementation. This part should be deliver in the 1.0.0 release.

All the very experimental part about northbound API would be moved in another project/repository.

(reading more about using Leshan in a cluster)

@sbernard31 sbernard31 added the discussion Discussion about anything label Apr 9, 2019
@sbernard31 sbernard31 changed the title Future of leshan-server-cluster Future of experimental leshan-server-cluster module Apr 9, 2019
@eliasweingaertner
Copy link

First of all, I agree: If the cluster implementation is not good enough for a 1.0.0 release, keep it out.

However, what I'd like have kept in the 1.0.0 would be stable interfaces for Observation and Registration stores:

This way, the actual implementation could be in leshan-server-redis, but the interface could stay in the leshan-server-cluster or simply in the server module.

Does this make sense?

@sbernard31
Copy link
Contributor Author

@eliasweingaertner to be more precise, the idea is to create a leshan-server-redis module which will be delivered in the 1.0.0 release and which will probably contain :

  • RedisRegistrationStore which stores Registration and Observation
  • RedisSecurityStore which stores SecurityInfos
  • RedisLock which is needed by both stores.

(the rest go in another repositoty)

RegistrationStore and SecurityStore implementation stay in leshan-server-core.

@GiacomoGenovese
Copy link

Hi All,
Please correct me if i'm wrong because I didn't investigate the cluster functionality.
The leshan-cluster is a datastore clustering based on Redis HA, isn't it?

@sbernard31
Copy link
Contributor Author

@GiacomoGenovese,

The leshan-cluster is a datastore clustering based on Redis HA, isn't it?

Yes and also an experimental northbound API which will be moved in its own experimental repository.

@sbernard31
Copy link
Contributor Author

I created a PR #705 which moves Redis stores in a new leshan-server-redis module.
Next milestone release will contain : leshan-server-redis and leshan-server-cluster.
After that I will move leshan-server-cluster in its own experimental project and leshan-server-cluster will not be released with Leshan anymore.

@sbernard31
Copy link
Contributor Author

#705 is integrated in master.
leshan-1.0.0-M12 will contain both projects leshan-server-redis and leshan-server-cluster.
leshan-server-cluster will be removed for leshan-1.0.0-M13.

@sbernard31
Copy link
Contributor Author

#741 is now integrated in master.
Meaning that leshan-server-cluster is no more available in master.
(leshan-server-redis is still there)

The last version of leshan-server-cluster is available in branch cluster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Discussion about anything
Projects
None yet
Development

No branches or pull requests

3 participants