Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify that HELP lines are not duplicated #638

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Verify that HELP lines are not duplicated #638

wants to merge 1 commit into from

Conversation

spyrkob
Copy link

@spyrkob spyrkob commented May 14, 2021

Fixes #616

@eclipse-microprofile-bot
Copy link
Contributor

Can one of the admins verify this patch?

@rafi0101
Copy link

What about this MR?
We are using version 5.1.0 and currently have the problem again with duplicate/multiple HELP messages for the same metric. I know this is just a MR for testing, but maybe this would be noticed then?

@rafi0101 rafi0101 mentioned this pull request Mar 22, 2024
Open
@Channyboy
Copy link
Contributor

Hi! We can fit it in into the next minor release (however, there are currently no active plans set for that).
On top of that, the PR would need to be updated to use the new query params pathing (i.e., /metrics?scope=application)

Channyboy
Channyboy reviewed Mar 28, 2024
View reviewed changes
tck/rest/src/main/java/org/eclipse/microprofile/metrics/test/MpMetricTest.java Outdated
@Test
@RunAsClient
public void testApplicationContainsHelpMessageOnce() {
given().header("Accept", TEXT_PLAIN).when().get("/metrics/application")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For metrics 5.x /metrics?scope=application

See: https://download.eclipse.org/microprofile/microprofile-metrics-5.1.1/microprofile-metrics-spec-5.1.1.html#scopes

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Channyboy thanks, I updated the PR could you take a look and let me know if it needs any other changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Channyboy Channyboy Channyboy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve TCK to verify that HELP lines are not duplicated
4 participants
@spyrkob @eclipse-microprofile-bot @rafi0101 @Channyboy