Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require specific sets of metrics when implementation is based on Micrometer #687

Open
donbourne opened this issue Jul 12, 2022 · 0 comments

Comments

@donbourne
Copy link
Member

In order to increase consistency of metrics available between vendors using Micrometer as their MP Metrics implementation we could have a required set of metrics. These would be the "base" scope metrics.

as an example of some of the metrics sets that we may want to require, see https://micrometer.io/docs/ref/jvm
new ClassLoaderMetrics().bindTo(registry); (1)
new JvmMemoryMetrics().bindTo(registry); (2)
new JvmGcMetrics().bindTo(registry); (3)
new ProcessorMetrics().bindTo(registry); (4)
new JvmThreadMetrics().bindTo(registry); (5)

note that in our group discussion from July 12, 2022 we hadn't fully decided whether this was a good idea. The "pro" side would be improved consistency, the "con" side would be tighter tie-in to Micrometer-specifics when using Micrometer.

@donbourne donbourne added this to the 5.0 milestone Jul 12, 2022
@donbourne donbourne removed this from the 5.0 milestone Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant