-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Folding #50
Comments
Do you have an estimation of the ratio of textmate grammars that do enable folding? does VSCode rely on it ? |
To be honnest with you, I don't remember. I must study again that but I'm very busy for the moment with JDT Codelens (an another project/topic). |
@micktaelistria the only thing that I can tell you is that VSCode uses by default the indent folding strategy that I have implemented for Eclipse https://github.com/angelozerr/typescript.java/blob/master/eclipse/ts.eclipse.ide.ui/src/ts/eclipse/ide/ui/folding/IndentFoldingStrategy.java Inside VSCode TypeScript, JSON, etc editor uses this folding strategy. I know you are working on folding feature for Generic Editor. IMHO, I think Generic Editor should use this indent folding strategy by default. |
I think Generic Editor should use this indent folding strategy by default.
I agree. Now that Generic Editor has an extension point for reconciler and
an example about folding, it shouldn't be that hard to add it. Can you
please open an enhancement request for that?
|
This bug exists https://bugs.eclipse.org/bugs/show_bug.cgi?id=512956 |
That bug is about providing the extension-point, not about providing some (default) implementation. |
|
Was it implemented in tm4e? How can I use it in generic editor to fold/unfold yaml or json? |
Today tm4e doesn't support code folding, but I tell me if it's a good idea since LSP4E supports now folding. For instance json language server supports folding. For yaml, I don't know. |
What's the status of this? |
Still open, looking for volunteers to fix it. |
TextMate grammar can define folding https://manual.macromates.com/en/navigation_overview
It should be cool if tm4e could provide the
org.eclipse.tm4e.ui.folding.TMFoldingStrategy
which supports this feature.The text was updated successfully, but these errors were encountered: