Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default theme can't be specified via plugin customization #713

Closed
iloveeclipse opened this issue Feb 16, 2024 · 5 comments
Closed

Default theme can't be specified via plugin customization #713

iloveeclipse opened this issue Feb 16, 2024 · 5 comments

Comments

@iloveeclipse
Copy link
Contributor

The code below only asks for a user preference, not for all possible configured preferences like plugin customization.
https://github.com/eclipse/tm4e/blob/e87d06b6a2afd5fbb2b68a91345508b1ce09b2ac/org.eclipse.tm4e.ui/src/main/java/org/eclipse/tm4e/ui/internal/themes/ThemeManager.java#L125

So plugin customization file that contains something like this doesn't work:

# Use "classic" theme for textmate
org.eclipse.tm4e.ui/org.eclipse.tm4e.ui.themes.defaultLightTheme=org.eclipse.tm4e.ui.themes.WtpXmlClassic

The right way is to read preferences from preferences service and write to the instance scope.

@sebthom
Copy link
Member

sebthom commented Feb 16, 2024

Before I start researching into Eclipse preferences. Could you give me a few lines of pseudo code, then I can change this.

@iloveeclipse
Copy link
Contributor Author

IPreferencesService preferenceService = Platform.getPreferencesService();
String value = preferenceService.getString(PLUGIN_ID, KEY, DEFAULT_VALUE, /* search in all scopes is null */ null);

@iloveeclipse
Copy link
Contributor Author

Verified fix #716 : works fine in 0.10.1.202402162114 version & product customization.

@iloveeclipse
Copy link
Contributor Author

@sebthom : do you plan to release 0.10.1 may be?
I'm particularly interested in #709 & #713 fixes.

@sebthom
Copy link
Member

sebthom commented Feb 19, 2024

@sebthom : do you plan to release 0.10.1 may be? I'm particularly interested in #709 & #713 fixes.

I just released it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants