-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default theme can't be specified via plugin customization #713
Labels
Comments
Before I start researching into Eclipse preferences. Could you give me a few lines of pseudo code, then I can change this. |
|
sebthom
added a commit
to sebthom/tm4e
that referenced
this issue
Feb 16, 2024
sebthom
added a commit
to sebthom/tm4e
that referenced
this issue
Feb 16, 2024
sebthom
added a commit
that referenced
this issue
Feb 16, 2024
Verified fix #716 : works fine in 0.10.1.202402162114 version & product customization. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The code below only asks for a user preference, not for all possible configured preferences like plugin customization.
https://github.com/eclipse/tm4e/blob/e87d06b6a2afd5fbb2b68a91345508b1ce09b2ac/org.eclipse.tm4e.ui/src/main/java/org/eclipse/tm4e/ui/internal/themes/ThemeManager.java#L125
So plugin customization file that contains something like this doesn't work:
The right way is to read preferences from preferences service and write to the instance scope.
The text was updated successfully, but these errors were encountered: