Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IncludeReference SELF definition is incorrect #723

Closed
janyou opened this issue Mar 4, 2024 · 1 comment
Closed

IncludeReference SELF definition is incorrect #723

janyou opened this issue Mar 4, 2024 · 1 comment

Comments

@janyou
Copy link

janyou commented Mar 4, 2024

https://github.com/eclipse/tm4e/blob/33dbe0128a1f061b422cc49ca61a5f1f94e4cf8e/org.eclipse.tm4e.core/src/main/java/org/eclipse/tm4e/core/internal/grammar/dependencies/IncludeReference.java#L37

Correct：
private static final IncludeReference SELF = new IncludeReference(Kind.Self, RawRepository.DOLLAR_SELF, "");

sebthom added a commit to sebthom/tm4e that referenced this issue Mar 4, 2024
@sebthom
fix: Wrong IncludeReference.Kind used for IncludeReference.SELF eclip…
277dc5a 
…se-tm4e#723
sebthom added a commit that referenced this issue Mar 4, 2024
@sebthom
fix: Wrong IncludeReference.Kind used for IncludeReference.SELF #723
a85cb2c
@sebthom
Copy link
Member

sebthom commented Mar 4, 2024

Good catch, thanks a lot!!

@sebthom sebthom closed this as completed Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sebthom @janyou