Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Preferences] Injection in Grammar Preferences #95

Open
angelozerr opened this issue Apr 28, 2017 · 3 comments
Open

[Preferences] Injection in Grammar Preferences #95

angelozerr opened this issue Apr 28, 2017 · 3 comments

Comments

@angelozerr
Copy link
Contributor

Grammar preferences doesn't show Injection information. It should be cool to see it and manage Injection with UI Preferences (external grammar)

@sebthom
Copy link
Member

sebthom commented Jun 22, 2022

I tried to work on this. I created a table to show the injections of the current scope and in my tests realized that the injection list is always empty. Apparently AbstractGrammarRegistryManager#getInjections only returns injections that were registered via the Eclipse extension point and does not return any injections declared in the textmate grammar files and available via IGrammar#getInjections() or IRawGrammer.getInjections(). Is that on purpose?

Additionally the injections registered via the extension point don't seem to be used anywhere in the code, so I wonder what these registrations are meant for.

@angelozerr I know you haven't worked much on tm4e lately but I would really appreciate if you are able to maybe give me some historical insight on this.

@sebthom
Copy link
Member

sebthom commented Jul 28, 2022

@mickaelistria since @angelozerr seems busy, can you shed some light on this?

@mickaelistria
Copy link
Contributor

To be honest, I don't know anything on this topic; I believe you're actually much more expert than I am in actual implementation of LSP4E nowadays ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants