fix: On enter rule don't use the proper insert spaces / tab width when those settings are changed

[angelozerr]

On enter rule don't use the proper insert spaces / tab width when those settings are changed

Fixes #460

Signed-off-by: azerr azerr@redhat.com

[angelozerr]

This PR requires eclipse-platform/eclipse.platform.text#108

[mickaelistria]

Instead of looking at properties, can't we try to first deduce the insert spaces/tabs from previous lines in the file? Usually this leads to good results.

[angelozerr]

The main problem with this strategy is when you have no spaces. Ex:

{}

When you type enter inside {|} you don't know the spaces / tabs to use.

[angelozerr]

Another problem is if you have this usecase comments with tabs and editor is configured with spaces:

/*
\t\t */
{|}

when you press on Enter, it will indent with tabs instead of spaces.

IMHO, the on enter rules should follow the editor configuration and not the previous line of document. The on enter rule is a magic indentation, it is a kind of formatting.

vsocde uses the editor settings too for this on enter rules and not the previous line text.

[angelozerr]

@mickaelistria why you have closed this PR?

[mickaelistria]

The master branch have been deleted, it's now main. I'll see whether it's possible to retarget this PR.

[mickaelistria]

I've restored master, can you please try retargetting the PR? IIRC it is doable from the GitHub UI.

[angelozerr]

@mickaelistria I created a new PR at #517 which use activate text editor and not the ITextEditorAware which doesn't exists for the moment in platform text. I think using activate text editor for strategy is correct.

[sebthom]

@angelozerr is this PR still relevant or can we close it?

[angelozerr]

@angelozerr is this PR still relevant or can we close it?

Yes it is relevant again, but I have not find time to rebase it from master.

[sebthom]

@angelozerr do you think this PR will ever happen? The required PR eclipse-platform/eclipse.platform.text#108 got closed without being merged.

[sebthom]

Closing this PR for now as ITextEditorAware doesn't seem to be coming. eclipse-platform/eclipse.platform.text#108 was been closed and there is no follow-up attempt in https://github.com/eclipse-platform/eclipse.platform.ui

The functional issue has already been solved by #517.

Feel free to reopen.