Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update language pack #550

Merged
merged 2 commits into from
Jun 11, 2023
Merged

fix: update language pack #550

merged 2 commits into from
Jun 11, 2023

Conversation

sebthom
Copy link
Member

@sebthom sebthom commented Jun 11, 2023

Solves #501, #545

@github-actions github-actions bot added the bug label Jun 11, 2023
@sebthom sebthom merged commit 4643498 into eclipse-tm4e:main Jun 11, 2023
@sebthom sebthom deleted the langpgk branch June 11, 2023 19:42
@mickaelistria
Copy link
Contributor

Note that if this comes from VSCode, an IP review is usually necessary.

@sebthom
Copy link
Member Author

sebthom commented Jun 12, 2023

Note that if this comes from VSCode, an IP review is usually necessary.

Thanks for the reminder. How do I trigger/request that? Is there some automatic IP approval process like with jar dependencies using the dash licenses check tool?

@mickaelistria
Copy link
Contributor

Unfortunately, there cannot be automated check for subcontents of the VSCode repo.
Usually, you can take the VSCode source zip and remove everything from it except the files you want IP check/approval for. Then create a new ticket at https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues , using one of the templates for easier progress and attach the trimmed zip to the ticket.

@sebthom
Copy link
Member Author

sebthom commented Jun 12, 2023

@mickaelistria I created this issue https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/8851 I hope it works like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants