feat: #572 Theme replicating the coloring of the WTP XML editor #573
Conversation
It is not perfect (some items share the same CSS), but is close enough.
|
Thanks @kevloral ! Could you add a screenshot with a sample just to see the result of your PR please. |
|
Perhaps we should find a new name than Tradional? WTP for instance? I suggest too to add your theme in the extensionpoint https://github.com/eclipse/tm4e/blob/88bb9c8d20b5c0bfb11573766fa709bba38323bf/org.eclipse.tm4e.ui/plugin.xml#L44 in order to TM4E provides this new theme. |
|
Actual WTP XML editor: With the Traditional theme: As you can see, the equals sign color does not match and the the highlighting is different too. |
New WTP XML Classic theme added
New WTP XML Classic theme added
|
The theme has been renamed (now it is called WTP XML Classic) and has been added to the plugin descriptor. |
sebthom
changed the title
|
@kevloral can you please bump the minor version in the MANIFEST.MF and pom.xml of the UI plugin. This should fix the build error |
|
Sure, but I do not know the policy you have wrt versioning. Would 0.7.1 be fine? Or should it be 0.8.0? Edit: I just noticed you said minor version. Ok. 0.8.0 then. |
Minor version increased (0.7.0 -> 0.8.0)
Minor version increased (0.7.0 -> 0.8.0)
The feature version must be updated too (0.6.0 -> 0.7.0)
The feature version must be updated too (0.6.0 -> 0.7.0)
|
Feature (org.eclipse.tm4e.feature) version updated (0.6.0 -> 0.7.0) too. |
|
GitHub says "@kevloral closed this by deleting the head repository". Is this intended? |
It is not perfect (some items share the same CSS), but it is close enough.