Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: parse/display config of indentation rules and colorized bracket pairs #675

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

sebthom
Copy link
Member

@sebthom sebthom commented Jan 29, 2024

This PR adds parsing of indentation rules and colorized bracket pairs from language-configuration.json and displays them via Windows > Preferences > Textmate >Language Configuration. This PR also changes the horizontal tabs to a vertical navigation list.

Before:
image

After:
image

@mickaelistria
Copy link
Contributor

By colorized bracket pairs, do you mean some "rainbow brackets"? If so, it's been a long requested feature, probably worth a screenshot and a noteworthy in next SimRel.

@sebthom
Copy link
Member Author

sebthom commented Jan 29, 2024

By colorized bracket pairs, do you mean some "rainbow brackets"? If so, it's been a long requested feature, probably worth a screenshot and a noteworthy in next SimRel.

"colorized bracket pairs" is the term used by vscode for "rainbow brackets".

So far I only implemented the parsing of the langcfg json and displaying the config. The config is not used/applied yet. This is the same for the Folding rules and Word Pattern which are currently only displayed for informational use.

My midterm goal is to expose the langcfg to other plugins. currently it is for internal use only

@mickaelistria
Copy link
Contributor

OK, thanks for the explanation.

@sebthom sebthom changed the title feat: parse/display indentation rules and colorized bracket pairs feat: parse/display config of indentation rules and colorized bracket pairs Jan 29, 2024
@sebthom sebthom merged commit 1d2beb8 into eclipse-tm4e:main Jan 29, 2024
9 checks passed
@sebthom sebthom deleted the improve branch January 29, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants