Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

[Language Server] Syntax Highlighting Support #283

Closed
chetanladdha opened this issue Feb 20, 2017 · 6 comments
Closed

[Language Server] Syntax Highlighting Support #283

chetanladdha opened this issue Feb 20, 2017 · 6 comments
Labels

Comments

@chetanladdha
Copy link

chetanladdha commented Feb 20, 2017

AFAIK, Xtext is not providing Syntax highlighting in a case of Language Server protocol.
As this is a very important feature for domain specific language, do we have any plan for providing syntax highlighting for Xtext generated LSP?

@chetanladdha chetanladdha changed the title Syntax Highlighting in case of Language Server [Language Server] Syntax Highlighting Support Feb 20, 2017
@cdietrich
Copy link
Member

@chetanladdha
Copy link
Author

chetanladdha commented Mar 10, 2017

@cdietrich : Do you know any workaround by which I can get the Syntax highlighting working in Xtext based language server? Is there any way through which I can get the the List of SymbolInformation ?

@cdietrich
Copy link
Member

Since this is. Client side thing you should look for how to do this on Che.

@cdietrich
Copy link
Member

I don't know if Che supports the symbol lookup from language server protocol.

@chetanladdha
Copy link
Author

Thanks for reply. I still have some problem in understanding:

  1. Does it mean Support semantic highlighting microsoft/language-server-protocol#18 has bug in itself for syntax highlighting implementation?
  2. Is there any enhancement request exist for supporting syntax highlighting in Xtext LSP?

@cdietrich
Copy link
Member

no this means: Microsoft says Syntax Highlighting is a Client Side Thing so it is part of the Che / VSCode what ever plugin and not the LS itself.

As long as LSP does not support it and thus no client supports it ....

LSP4j has LanguageClientExtensions anyway which offers you a server to client push regarding coloring. Xtext Basically supports/Implements that (you need actually to bind it)

 def Class<? extends IColoringService> bindIColoringService() {
    	return ColoringServiceImpl;
    }

But as said before: if you dont have a client that understands that .....

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants