Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ObjectRenderer removes whole ui schema when any contained element is deleted #115

Open
sdirix opened this issue Dec 15, 2020 · 0 comments
Open
Labels
bug Something isn't working

Comments

@sdirix
Copy link
Member

sdirix commented Dec 15, 2020

Description
The ObjectRenderer (currently only available when manually editing the ui schema) renders a group with controls for all contained properties. All these elements are shown as deletable. If any of them is deleted, the whole ui schema is removed.

To reproduce
Steps to reproduce the behavior:

  1. Go to https://jsonforms-editor.netlify.app/
  2. Use the following ui schema
    {
      "type": "VerticalLayout",
      "elements": [
        {
          "type": "Control",
          "scope": "#/properties/name"
        },
        {
          "type": "Control",
          "scope": "#/properties/personalData"
        }
      ]
    }
  3. Delete any of the object elements

Expected behavior
Delete should not be offered on any of the object elements

Screenshots
DeleteOnObject

@sdirix sdirix added the bug Something isn't working label Dec 15, 2020
@sdirix sdirix changed the title Fix ObjectRenderer ObjectRenderer removes whole ui schema when any contained element is deleted Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant