Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyfdb should not depend on tox #39

Closed
Tracked by #10
juntyr opened this issue Dec 12, 2024 · 3 comments
Closed
Tracked by #10

pyfdb should not depend on tox #39

juntyr opened this issue Dec 12, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@juntyr
Copy link

juntyr commented Dec 12, 2024

What happened?

tox is a dev-dependency, not a dependency. Right now, installing pyfdb requires installing tox, which can result in version conflicts.

tox should be moved into an optional dependency, e.g. the test one.

What are the steps to reproduce the bug?

N/A

Version

v0.1.0

Platform (OS and architecture)

N/A

Relevant log output

No response

Accompanying data

No response

Organisation

University of Helsinki

@juntyr juntyr added the bug Something isn't working label Dec 12, 2024
@juntyr
Copy link
Author

juntyr commented Dec 12, 2024

I'd really appreciate if a minor release with this issue fixed could be released in the next few days.

cc @SF-N

@juntyr juntyr mentioned this issue Dec 12, 2024
27 tasks
@tbkr
Copy link
Collaborator

tbkr commented Dec 18, 2024

Hey @juntyr,

sorry for the late response. I just pushed a version without the tox dependency to pypi. The newest version is no 0.1.1. You can find it in the optional dependencies called "dev" in case you need it.

Let me know, if you run into other issues. I'd close the issue for now.

Happy holidays in every case :)

@tbkr tbkr closed this as completed Dec 18, 2024
@juntyr
Copy link
Author

juntyr commented Dec 18, 2024

Thank you @tbkr for fixing the issue so quickly, everything works now :)

Happy holidays to you as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants