Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mitigate inconsistencies from unknown graph-node feature support #526

Open
3 of 8 tasks
Theodus opened this issue Jan 10, 2024 · 1 comment
Open
3 of 8 tasks

mitigate inconsistencies from unknown graph-node feature support #526

Theodus opened this issue Jan 10, 2024 · 1 comment

Comments

@Theodus
Copy link
Member

Theodus commented Jan 10, 2024

This is a temporary measure to mitigate inconsistencies that arise from indexers serving queries with different versions of graph-node. The gateway must enforce some feature set. This followup should be to support versioned queries (GIP-24) in indexer-service and the gateway.

TODO

  • merge feat(indexer-service): Add graph-node version endpoint from status api graphprotocol/indexer#841, release to indexers ASAP
  • add a config field for min_graph_node_version, enforce via a filter in indexing_status.rs.
  • set minimum graph-node version to 0.33.0, but allow unknown graph-node version for now.
  • transition to strict enforcement, after substantial indexer adoption of the updated indexer-service
  • GIP-24
    • add indexer-service support for versioned queries
    • add the new version field to attestations, such that the gateway supports both for the transition period
    • add gateway support for the above
@Theodus Theodus changed the title feat: support minimum graph-node version mitigate inconsistencies from unknown graph-node feature support Jan 10, 2024
@Theodus
Copy link
Member Author

Theodus commented Dec 2, 2024

blocked by graphprotocol/indexer-rs#527

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant