Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Consume MakeItRun rename to Run #188

Merged
merged 1 commit into from
May 9, 2023

Conversation

lenny-goodell
Copy link
Member

@lenny-goodell lenny-goodell commented May 8, 2023

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/app-rfid-llrp-inventory/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) N/A
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)
    refactor: Rename MakeItRun/MakeItStop to Run/Stop edgex-docs#1060

Testing Instructions

Run non-secure EdgeX
Build App LLRP
Run App LLRP with -cp -d
Verify service starts up and is waiting for messages

New Dependency Instructions (If applicable)

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
@lenny-goodell lenny-goodell added the tech-debt issue_type denoting refactoring to improve design or removal of temporary workarounds label May 8, 2023
@lenny-goodell lenny-goodell added this to the Minnesota milestone May 8, 2023
@lenny-goodell lenny-goodell merged commit cc44783 into edgexfoundry:main May 9, 2023
@lenny-goodell lenny-goodell deleted the run branch May 9, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt issue_type denoting refactoring to improve design or removal of temporary workarounds
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants