Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs:updated validation metrics with Hikvision camera #218

Merged

Conversation

vyshali-chitikeshi
Copy link
Contributor

@vyshali-chitikeshi vyshali-chitikeshi commented Jan 19, 2023

Signed-off-by: vyshali-chitikeshi vyshali.chitikeshi@intel.com

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

@codecov-commenter
Copy link

Codecov Report

Merging #218 (40714b3) into main (6741b26) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #218   +/-   ##
=======================================
  Coverage   31.77%   31.77%           
=======================================
  Files          18       18           
  Lines        1822     1822           
=======================================
  Hits          579      579           
  Misses       1179     1179           
  Partials       64       64           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

doc/ONVIF-protocol.md Outdated Show resolved Hide resolved
presatish
presatish previously approved these changes Jan 19, 2023
Copy link
Contributor

@presatish presatish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: vyshali-chitikeshi <vyshali.chitikeshi@intel.com>
@presatish presatish merged commit 35c6aae into edgexfoundry:main Jan 24, 2023
@presatish presatish deleted the validation_metrics branch January 24, 2023 17:52
@presatish presatish restored the validation_metrics branch January 24, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants