Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Consume Provision Watcher changes for running multiple instances #349

Merged
merged 1 commit into from
May 9, 2023
Merged

refactor: Consume Provision Watcher changes for running multiple instances #349

merged 1 commit into from
May 9, 2023

Conversation

lenny-goodell
Copy link
Member

@lenny-goodell lenny-goodell commented May 9, 2023

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) N/A
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?) N/A

Testing Instructions

Run non-secure EdgeX Stack
Build service from this PR branch
run service with -cp -d -o flags
Verify service starts w/o errors and logs have the following

msg="ProvisionWatcher Generic-Onvif-Provision-Watcher not found in Metadata, adding it..."
"provision watcher Generic-Onvif-Provision-Watcher added"

Restart the service with the -cp -d -o -i 1 flags
Verify service starts w/o errors and logs have the following

"ProvisionWatcher Generic-Onvif-Provision-Watcher exists, using the existing one"

New Dependency Instructions (If applicable)

…ances

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
@lenny-goodell lenny-goodell merged commit 1961be3 into edgexfoundry:main May 9, 2023
@lenny-goodell lenny-goodell deleted the provision-watcher branch May 9, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants