Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a way to remove device service safely on GUI #426

Open
badboy-huaqiao opened this issue Aug 9, 2021 · 3 comments
Open

Is there a way to remove device service safely on GUI #426

badboy-huaqiao opened this issue Aug 9, 2021 · 3 comments

Comments

@badboy-huaqiao
Copy link
Member

badboy-huaqiao commented Aug 9, 2021

right now, device service is not allowed user to remove device service metadata from GUI, because this is a fatal operation if the device service deleted is running.

but users do have a need to delete a tested or dead device service, so GUI needs to figure out how to remove a device service safely.

@badboy-huaqiao
Copy link
Member Author

badboy-huaqiao commented Aug 9, 2021

After research, when GUI is calling the delete api of device service, it will not allow to be removed if the device service associated devices exits, that's a good validation, but GUI still needs to consider do somethings validation before removing a running service, such as figuring out if the device service running or dead, and how to remove the associated dead docker container.

@badboy-huaqiao badboy-huaqiao changed the title Is there a way to remove device service on GUI security Is there a way to remove device service safely on GUI Aug 23, 2021
@tonyespy
Copy link
Member

tonyespy commented Oct 9, 2021

If a device service cannot be removed using via Core Metadata, then the UI shouldn't try to work around this.

Also regarding removing docker containers, by default EdgeX docker containers are deployed using docker-compose. As such, I don't think adding docker service management functionality to the UI makes sense. IMOP these operations should be outside of the scope of the UI.

@badboy-huaqiao
Copy link
Member Author

badboy-huaqiao commented Oct 10, 2021

@tonyespy hi, I agree with you. but one day, a user came to me and told me he have a bad device service is dead, he want to replace the dead device servicce with a new one with the same features, like device service name, port... but it looks like the metadata service did't do the right update work, so he want to remove metadata of the bad device service, but he found he can't do that on GUI, and he also was not familiar with the api of metadata how to remove a bad device service metadata, and I told him to use some tools like Postman to call the remove API of metadata service, and he did succeed, but he thought it was a bad user experience for a GUI, I think he is right, as a application GUI let users to call api with some tools like Postman is really a bad user experience, that's why I want to find out some better way imporving user experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants