Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Out of bounds array access causing glitched card display #250

Closed
edo9300 opened this issue Sep 23, 2022 · 0 comments
Closed

Out of bounds array access causing glitched card display #250

edo9300 opened this issue Sep 23, 2022 · 0 comments

Comments

@edo9300
Copy link
Owner

edo9300 commented Sep 23, 2022

When resolving a MSG_SORT_CARD or MSG_SORT_CHAIN message,

std::vector<int> sort_list;
gets populated, and is then cleared when the client sends the selection.
If the duel is terminated while the card list is still showing, that vector will never be cleared, and the next time a card selection that has more than 5 cards is performed and the scrollbar is scrolled, the client will take the wrong path in the scroll handling
if(sort_list.size()) {
and will attempt to read the sort_list array, very likely performing an out of bound read, and if not crashing displaying a "glitched" card selection window
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant