Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forwarding history issues #105

Open
rkfg opened this issue Jan 4, 2023 · 2 comments
Open

Forwarding history issues #105

rkfg opened this issue Jan 4, 2023 · 2 comments

Comments

@rkfg
Copy link
Contributor

rkfg commented Jan 4, 2023

@hieblmi I found multiple issues with the new tab:

  • columns are not aligned properly if there are emojis in the alias (see my code for columns in other tabs):
    2023-01-04_03-33-35
  • aliases are justified by the left side in other tabs but here they're justified by the right side
  • this tab loads really slowly, takes about a minute on RPi, I limited the number of records to 1024 and start time is -12h. I think it shouldn't take this long if data is cached properly, last 1024 events are returned instantly with lncli fwdinghistory --max_events 1024
  • Enter does nothing here: 2023-01-04_03-39-42
  • lntop crashes on startup if [views.fwdinghist] section doesn't exist in the config, not a good UX for people who've just updated the binary but not the config; I guess populating the options with sane defaults would be nice
@hieblmi
Copy link
Contributor

hieblmi commented Jan 4, 2023

Thanks @rkfg for summarizing your findings. I will get to them in a bit.

@hieblmi
Copy link
Contributor

hieblmi commented May 3, 2024

Fixed the slowness issue here: #113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants