Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GSL dependency #103

Open
2 tasks done
csparker247 opened this issue Aug 16, 2024 · 1 comment
Open
2 tasks done

Remove GSL dependency #103

csparker247 opened this issue Aug 16, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@csparker247
Copy link
Member

csparker247 commented Aug 16, 2024

What problem is your feature request solving?

#101 introduces the GNU Scientific Library (GSL) as a private dependency for the segmentation library. Specifically, the new CubicSplineMT class uses gsl_integration_qags to calculate the spline length.

While GSL is widely supported across platforms, I don't love adding an external library dependency when we're basically just using one function.

What is your feature request?

We should explore alternative methods for efficiently estimating the spline length. For example, we might roll our own templated version of the QAGS algorithm [pdf] and compare the performance.

What alternative solutions have you considered?

No response

Is there anything else we should know that wasn't included already?

No response

Are you proposing to work on this feature yourself?

  • I am willing to submit a pull request for this feature

Code of Conduct

  • I agree to follow this project's Code of Conduct
@csparker247 csparker247 added the enhancement New feature or request label Aug 16, 2024
@csparker247
Copy link
Member Author

Another idea: let the backend be selectable.

Boost provides integration via quadrature: https://www.boost.org/doc/libs/1_86_0/libs/math/doc/html/quadrature.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant