Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced code block option to disable line numbers #159

Closed
awdeorio opened this issue Mar 11, 2022 · 4 comments
Closed

Enhanced code block option to disable line numbers #159

awdeorio opened this issue Mar 11, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@awdeorio
Copy link
Contributor

awdeorio commented Mar 11, 2022

Is your feature request related to a problem? Please describe.

In rare cases, the line numbers on enhanced code blocks can be confusing. From the EECS 485 P5 spec, there's an example where the output of a code block is a number, which is easily confused with the line number.

p5-confusing-number

Describe the solution you'd like

An option to disable line numbers on an enhanced code block would be nice.

Describe alternatives you've considered

I used {: data-variant="legacy" }, but the downside is an inconsistent look and feel next to the other code blocks.

@awdeorio awdeorio added the enhancement New feature or request label Mar 11, 2022
@seshrs
Copy link
Member

seshrs commented Mar 15, 2022

Thanks for reporting! I think it's quite reasonable to want to turn line-numbers off. I think I can provide an option to simply not display line numbers, maybe an option like data-variant="no-line-numbers". Or maybe a new option like data-line-numbers="false" or something like that.

Do you need this for this semester? If it can wait for next semester, I'd prefer to address it in a couple of weeks once my personal life settles down a bit :)

@awdeorio
Copy link
Contributor Author

This is totally low priority!

@seshrs
Copy link
Member

seshrs commented Apr 13, 2022

Reminder that #165 will be included in the SP/SU 22 release (currently aiming for April 30). I'm going to keep this issue open for now, and will close it after v1.7.0 has been published.

@seshrs
Copy link
Member

seshrs commented Apr 28, 2022

@awdeorio I just released v1.7.0! I'm going to close this issue, but please follow up if you're running into issues. Thanks!

@seshrs seshrs closed this as completed Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants