Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump header level styles in sidebar if needed #204

Closed
seshrs opened this issue Aug 31, 2022 · 1 comment · Fixed by #205 or #206
Closed

Bump header level styles in sidebar if needed #204

seshrs opened this issue Aug 31, 2022 · 1 comment · Fixed by #205 or #206
Labels
enhancement New feature or request

Comments

@seshrs
Copy link
Member

seshrs commented Aug 31, 2022

Currently, Primer Spec adds a little border for smaller headings underneath a H1. However, if the top-level heading is a H2, the style doesn’t appear.

I think it makes sense to bump all header level styles in the sidebar so that the highest-found header level is styled as a H1.


Tangent: I wonder if we should also auto-ignore the first title H1 of the page from the sidebar. Or maybe it should be presented differently in the sidebar? I think I want to explore alternative header designs a bit more.

But maybe we should provide an option to

@seshrs seshrs added the enhancement New feature or request label Aug 31, 2022
@awdeorio
Copy link
Contributor

Tangent: I wonder if we should also auto-ignore the first title H1 of the page from the sidebar. Or maybe it should be presented differently in the sidebar? I think I want to explore alternative header designs a bit more.

I think this idea makes sense. Typically, a document with have an H1 (the title). All sections of the doc will be H2 and lower. Usually, the title of a document does not appear in a table of contents. Perhaps default to hiding the first H1, with an option to show?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants