-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can no longer import isomorphic-git #224
Comments
We had a bug where we were accidentally providing automatic polyfills for that and several other node built-in packages, but we fixed the bug. And unfortunately due to the "only one copy must win" nature of ember-auto-import, there's not much way to gracefully roll out this bugfix (apps and addons can all update independently and all of them must be prepared to deal with the new version taking over). Sorry it bit you. See also previous #218 (comment) You can affirmatively add the polyfill like: autoImport: {
webpack: {
node: {
path: true
}
} |
Ah, I was hoping this was the issue. Thanks |
This fixes a test failure that began appearing after upgrading ember-auto-import, which stopped automatically enabling webpack polyfills in v1.4.0. See the URLs below for more details: https://github.com/ef4/ember-auto-import#i-upgraded-my-ember-auto-import-version-and-now-things-dont-import-what-changed embroider-build/ember-auto-import#224 (comment) https://webpack.js.org/configuration/node/ This commit also drops `ember-cli-htmlbars-inline-precompile` since it is now deprecated and no longer needed.
* chore: ember-cli-update --to 3.13.1 Also mass-upgrade dependencies * fix: re-enable node polyfills in ember-auto-import This fixes a test failure that began appearing after upgrading ember-auto-import, which stopped automatically enabling webpack polyfills in v1.4.0. See the URLs below for more details: https://github.com/ef4/ember-auto-import#i-upgraded-my-ember-auto-import-version-and-now-things-dont-import-what-changed embroider-build/ember-auto-import#224 (comment) https://webpack.js.org/configuration/node/ This commit also drops `ember-cli-htmlbars-inline-precompile` since it is now deprecated and no longer needed. * ci: test on node 8 * ci: increase memory limit to 2GiB This is to work around what appears to be a problem with babel/ember-cli-babel/... on node 8 / 10.
* chore: ember-cli-update --to 3.13.1 Also mass-upgrade dependencies * fix: re-enable node polyfills in ember-auto-import This fixes a test failure that began appearing after upgrading ember-auto-import, which stopped automatically enabling webpack polyfills in v1.4.0. See the URLs below for more details: https://github.com/ef4/ember-auto-import#i-upgraded-my-ember-auto-import-version-and-now-things-dont-import-what-changed embroider-build/ember-auto-import#224 (comment) https://webpack.js.org/configuration/node/ This commit also drops `ember-cli-htmlbars-inline-precompile` since it is now deprecated and no longer needed. * ci: test on node 8 * ci: increase memory limit to 2GiB This is to work around what appears to be a problem with babel/ember-cli-babel/... on node 8 / 10.
The text was updated successfully, but these errors were encountered: