feat: support function to set domain #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #38 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 203 207 +4
Branches 51 52 +1
=========================================
+ Hits 203 207 +4
☔ View full report in Codecov by Sentry. |
fengmk2
reviewed
Aug 4, 2023
fengmk2
pushed a commit
that referenced
this pull request
Aug 4, 2023
[skip ci] ## [2.7.0](v2.6.1...v2.7.0) (2023-08-04) ### Features * support function to set domain ([#38](#38)) ([c73b415](c73b415))
|
🎉 This PR is included in version 2.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
fengmk2
reviewed
Aug 4, 2023
| @@ -28,7 +28,11 @@ class Cookie { | |||
| this.value = value || ''; | |||
| this.attrs = mergeDefaultAttrs(attrs); | |||
| assert(!this.attrs.path || fieldContentRegExp.test(this.attrs.path), 'argument option path is invalid'); | |||
| assert(!this.attrs.domain || fieldContentRegExp.test(this.attrs.domain), 'argument option domain is invalid'); | |||
| assert(!this.attrs.domain || typeof this.attrs.domain === 'string' || typeof this.attrs.domain === 'function', 'argument option domain is invalid'); | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
nodejs.AssertionError: argument option domain is invalid
at new Cookie (/home/admin/app/node_modules/_egg-cookies@2.7.0@egg-cookies/lib/cookie.js:35:5)
at Cookies.set (/home/admin/app/node_modules/_egg-cookies@2.7.0@egg-cookies/lib/cookies.js:124:20)
at updateCookie (/home/admin/app/node_modules/_koa-locales@1.12.0@koa-locales/index.js:254:17)
at Object.app.context.__getLocale (/home/admin/app/node_modules/_koa-locales@1.12.0@koa-locales/index.js:224:7)
at Object.get locale [as locale] (/home/admin/app/node_modules/_egg-i18n@2.1.1@egg-i18n/app/extend/context.js:10:17)
fengmk2
added a commit
that referenced
this pull request
Aug 4, 2023
fengmk2
added a commit
that referenced
this pull request
Aug 4, 2023
closes #38 (comment) remove debug deps
fengmk2
pushed a commit
that referenced
this pull request
Aug 4, 2023
[skip ci] ## [2.7.1](v2.7.0...v2.7.1) (2023-08-04) ### Bug Fixes * domain can be empty string ([#39](#39)) ([0b285e1](0b285e1)), closes [/github.com//pull/38#discussion_r1284672929](https://github.com/eggjs//github.com/eggjs/egg-cookies/pull/38/issues/discussion_r1284672929)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change
由于 set-cookies 时无法设置多 domain
支持 domain 传入函数，当有多个不同域名访问时，可由用户自定义动态设置 domain，示例如下