From 9b87b5923ac8d117390fa5ec3935debbb13aee26 Mon Sep 17 00:00:00 2001
From: Evan Hallein <ehallein@icloud.com>
Date: Fri, 20 Oct 2023 13:05:48 +0800
Subject: [PATCH] httpstreaming working correctly

---
 observations/urls.py  |  1 -
 observations/views.py | 57 ++++++++++++++++++++-----------------------
 2 files changed, 26 insertions(+), 32 deletions(-)

diff --git a/observations/urls.py b/observations/urls.py
index d973e2a83..b9125a276 100644
--- a/observations/urls.py
+++ b/observations/urls.py
@@ -21,7 +21,6 @@
     path("turtle-nest-encounters/<int:pk>/reject/", views.TurtleNestEncounterReject.as_view(), name="turtlenestencounter-reject"),
     path("line-transect-encounters/", views.LineTransectEncounterList.as_view(), name="linetransectencounter-list"),
     path("line-transect-encounters/<int:pk>/", views.LineTransectEncounterDetail.as_view(), name="linetransectencounter-detail"),
-    path('dbdump/', views.dbdump, name='dbdump'),
 ]
     
 
diff --git a/observations/views.py b/observations/views.py
index 29e3746ea..49d612fc2 100644
--- a/observations/views.py
+++ b/observations/views.py
@@ -8,13 +8,13 @@
 from django.views.generic.detail import SingleObjectMixin
 from django_fsm_log.models import StateLog
 from wastd.utils import ListViewBreadcrumbMixin, DetailViewBreadcrumbMixin, ResourceDownloadMixin
-#from django.http import JsonResponse
 from django.db import connection
 from django.http import StreamingHttpResponse
 import json
 import datetime
 
 
+
 from .admin import (
     EncounterAdmin,
     AnimalEncounterAdmin,
@@ -419,19 +419,8 @@ def dbdump(request):
 ORDER BY 
     e."when" DESC
     '''
-    with connection.cursor() as cursor:
-        cursor.execute(query)
-        # Fetch column names from the cursor description
-        columns = [col[0] for col in cursor.description]
-        # Convert the result to a list of dictionaries
-        results = [
-            dict(zip(columns, row))
-            for row in cursor.fetchall()
-        ]
-
-    # Use StreamingHttpResponse with the generator function
-    response = StreamingHttpResponse(stream_json(results), content_type='application/json')
-    
+ 
+    response = StreamingHttpResponse(stream_data(query), content_type="application/json")
     return response
 
 class DateTimeEncoder(json.JSONEncoder):
@@ -440,21 +429,27 @@ def default(self, obj):
             return obj.isoformat()
         return super(DateTimeEncoder, self).default(obj)
 
-def stream_json(data):
-    # Yield the start of the JSON list
-    yield '['
-    
-    first = True
-    for item in data:
-        # If not the first item, yield a comma
-        if not first:
-            yield ','
-        else:
-            first = False
+def stream_data(query):
+    with connection.cursor() as cursor:
+        cursor.execute(query)
         
-        # Yield the serialized item using the custom encoder
-        yield json.dumps(item, cls=DateTimeEncoder)
-    
-    # Yield the end of the JSON list
-    yield ']'
-
+        # Get column names from cursor.description
+        columns = [col[0] for col in cursor.description]
+        
+        yield '['  # Start of JSON array
+        first_row = True
+        row = cursor.fetchone()
+        while row:
+            if not first_row:
+                yield ','
+            else:
+                first_row = False
+            
+            # Convert row data to dictionary with column names as keys
+            row_dict = dict(zip(columns, row))
+            
+            # Convert the dictionary to JSON and yield
+            yield json.dumps(row_dict, cls=DateTimeEncoder)
+            
+            row = cursor.fetchone()
+        yield ']'  # End of JSON array