Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing cleanup when creating random templates #298

Closed
6 tasks
chevalleyc opened this issue Jan 18, 2022 · 0 comments · Fixed by #299
Closed
6 tasks

Missing cleanup when creating random templates #298

chevalleyc opened this issue Jan 18, 2022 · 0 comments · Fixed by #299
Labels
bug Something isn't working

Comments

@chevalleyc
Copy link
Contributor

Configuration information

"ehrbase_version": "0.19.0-SNAPSHOT",
"openehr_sdk_version": "1.7.0-SNAPSHOT",
"archie_version": "1.0.4",
"jvm_version": "Oracle Corporation 11.0.13+10-LTS-370",
"os_version": "Linux amd64 5.4.0-91-generic",
"postgres_version": "PostgreSQL 12.9 (Ubuntu 12.9-0ubuntu0.20.04.1) on x86_64-pc-linux-gnu, compiled by gcc (Ubuntu 9.3.0-17ubuntu1~20.04) 9.3.0, 64-bit"

Steps to reproduce

Integration test DefaultRestTemplateEndpointIT creates several templates with random version ids which causes issues with other tests when run locally (AqlTestIT). In particular, translated SQL is bloated with unnecessary UNIONs. One of the side effect is that checked cardinality of results doesn't match since UNION is present causing duplicated values to be eliminated (similarly to an explicit DISTINCT).

Actual result

The created templates remain in the DB after running the tests

Expected result (Acceptance Criteria)

The created templates are deleted from the DB

Definition of Done

  • The defect is checked by an unit or an integration test (Robot)
  • Merge Request approved
  • Unit tests passed
  • Build without errors
  • Release notes prepared
  • No additional runtime warnings
@chevalleyc chevalleyc added the bug Something isn't working label Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant