Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated code in Analysis-derived classes should be moved to base class Analysis #217

Open
c-dilks opened this issue Nov 30, 2022 · 1 comment
Labels
good first issue Good for newcomers

Comments

@c-dilks
Copy link
Member

c-dilks commented Nov 30, 2022

Or to CommonConstants or DataModel, wherever makes sense. We should try to avoid duplicating code between the derived classes.

Originally posted by @c-dilks in #208 (comment)

@c-dilks
Copy link
Member Author

c-dilks commented Dec 15, 2022

Example:

      double mass_ = (fabs(pid_)==211)?constants::pimass:(fabs(pid_)==321)?constants::kmass:(fabs(pid_)==11)?constants::emass:(fabs(pid_)==13)?constants::mumass:(fabs(pid_)==2212)?constants::pmass:0.;

Could use common PDG data code (ROOT?)

@c-dilks c-dilks added the good first issue Good for newcomers label Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant