Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eik-cli doesn't work on Windows #302

Closed
rlf opened this issue Jul 5, 2024 · 2 comments · Fixed by #303 or eik-lib/cli#584
Closed

Eik-cli doesn't work on Windows #302

rlf opened this issue Jul 5, 2024 · 2 comments · Fixed by #303 or eik-lib/cli#584
Assignees

Comments

@rlf
Copy link

rlf commented Jul 5, 2024

It turns out the eik-cli relies on the glob module, which doesn't really work with the windows folder-separator.

See https://stackoverflow.com/questions/72313482/glob-paths-dont-work-in-my-windows-environment

Ref: https://github.com/eik-lib/common/blob/master/lib/helpers/resolve-files.js#L42

Reproduce:

try running `npm eik publish --debug` on any windows machine with a `files` pattern targetting any folder.
@wkillerud wkillerud self-assigned this Jul 5, 2024
@wkillerud wkillerud linked a pull request Jul 5, 2024 that will close this issue
@wkillerud wkillerud moved this to In Progress in Cross-platform support Jul 9, 2024
@wkillerud wkillerud moved this from In Progress to Review in Cross-platform support Jul 11, 2024
@wkillerud wkillerud moved this from Review to In Progress in Cross-platform support Aug 15, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Cross-platform support Aug 16, 2024
@wkillerud
Copy link
Contributor

It'll take a bit more for the CLI package to run on Windows. This PR is for the CLI module:
https://github.com/eik-lib/cli/pull/584/files

@wkillerud
Copy link
Contributor

This should be fixed in v3.1.3 @rlf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
2 participants