Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stderr output does not imply error #833

Closed
cowwoc opened this issue Aug 6, 2019 · 2 comments · Fixed by #834
Closed

stderr output does not imply error #833

cowwoc opened this issue Aug 6, 2019 · 2 comments · Fixed by #834

Comments

@cowwoc
Copy link
Contributor

cowwoc commented Aug 6, 2019

Looking at webpack/webpack-cli#1017 (comment) and the various examples mentioned at #584 it's pretty clear that flagging all stderr output as [ERROR] is a but, not a feature.

Please add an option to disable this feature... ideally by default. At the very least we should be able to disable it if we want to.

Secondly, is there any chance of us getting colored output? Maven 3.5.0+ outputs ANSI colors. Yarn outputs ANSI colors. But when we run Yarn through this plugin we lose all colors. Instead of redirecting output to the log, would it help to output to stdout, stderr directly instead?

@cowwoc
Copy link
Contributor Author

cowwoc commented Aug 6, 2019

@eirslett So #834 fixes the first part of this issue. Do you have any ideas about the second part (color support)?

@eirslett
Copy link
Owner

eirslett commented Aug 7, 2019

I'm not so sure about the colors... also not too happy about forwarding stdout directly to system.out, since it's useful to use Maven's logging abstraction - potentially users might have some custom logging configuration, which will be respected with this plugin, when it uses Maven's logging abstraction.
Maybe Maven has changed its plugin API in 3.5.0 to support colors?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants