Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support for custom elements in SitemapStream #412

Open
tryggve opened this issue Apr 18, 2023 · 0 comments
Open

[Feature] Support for custom elements in SitemapStream #412

tryggve opened this issue Apr 18, 2023 · 0 comments

Comments

@tryggve
Copy link

tryggve commented Apr 18, 2023

Hi, I find this library really useful and helpful. Thank you for this project!

Describe the solution you'd like
I want the ability to extend the sitemap protocol with my own custom elements.

Additional context
According to the sitemap specification it is possible to extend the sitemap with custom elements.

There are some suggestions in the readme files that this is supported already so maybe I am missing something?

The ability to extend the xmlns with a custom namespace opens the door. Also in the API docs for SitemapStream there is a hint of this functionality where there is a custom namespace declared (commented out, but still).

But when checking the implementation for SitemapItemStream it is very bound to the known properties of the current sitemap protocol and supported extensions of news, links, videos etc.
If I try to pass in my custom properties to the stream they are simply ignored.

Thanks again for this great library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant