Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Cluster Admins/Creators ability to specify multiple AWS IAM Roles/Users and map those to RBAC Roles in EKS at Cluster Creation #1695

Closed
mohalone911 opened this issue Jan 2, 2020 · 11 comments
Labels
kind/feature New feature or request priority/backlog Not staffed at the moment. Help wanted. stale

Comments

@mohalone911
Copy link

Why do you want this feature?
Today, only the Cluster Creator has the permission to manage EKS Cluster just after creation (AWS IAM Role or User) and then if the Cluster Creator has to delegate the Cluster Access or management to other users/roles, we need to manually edit the aws-auth configmap or use the eksctl iam-identity-mappings command (https://eksctl.io/usage/iam-identity-mappings/ ). This is an extra hop and at the same time, users might end up editing the aws-auth configmap incorrectly, causing issues (as bad as loosing access to the entire cluster).

What feature/behavior/change do you want?
Let a user (Cluster Creator) supply multiple ARNs which can be added to the aws-auth configmap as admins or read-only roles etc. Basically, setting different IAM Roles/Users mapping to RBAC Roles at the cluster creation itself.

e.g. eksctl create cluster --ClusterAdminIAMRoleArns ( accepts string values which are AWS IAM ARNS for IAM Roles/users and maps these to "system:masters" group in Kubernetes RBAC" ) --ClusterWatcher(orReadOnly)IAMRoleArns (also accepts string values which are IAM AWS ARNS for IAM Roles and maps these to groups like "system:basic-user" or inbuilt ClusterRole "view" in Kubernetes RBAC "

This will make it easier for the ClusterAdmins/Customers to just create the cluster and after that delegate control to respective teams/users rather than coming back later and editing the aws-auth configmap.

@mohalone911 mohalone911 added the kind/feature New feature or request label Jan 2, 2020
@nemo83
Copy link

nemo83 commented Feb 25, 2020

This looks like a duplicate of: aws/containers-roadmap#185

@martina-if martina-if added the priority/backlog Not staffed at the moment. Help wanted. label Sep 11, 2020
@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the stale label Jan 18, 2021
@michaelbeaumont
Copy link
Contributor

Duplicate of #874

@michaelbeaumont michaelbeaumont marked this as a duplicate of #874 Jan 19, 2021
@michaelbeaumont
Copy link
Contributor

@aclevername Will this be covered by #3097 / #874?

@aclevername
Copy link
Contributor

@aclevername Will this be covered by #3097 / #874?

If I'm reading the issue correctly the desired functionality that doesn't exist is to map RBAC Roles at the cluster creation itself, currently its a manual command you have to do afterwards and can't be specified in a configmap. The PR is currently only intended to add cluster config support, it does not add it as part of cluster creation but I'm happy for that to get included as this sounds reasonable and an inexpensive addition

@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the stale label Feb 19, 2021
@mohalone911
Copy link
Author

@aclevername I think we should be good as long as users can supply additional IAM User/Role ARNs to be added to the configmap at the cluster creation time , when using eksctl.

@github-actions github-actions bot removed the stale label Feb 20, 2021
@djabraham
Copy link

Say the cluster creator left the company and someone corrupted the yaml config map with a single extra space.

At that point, would the entire cluster require a rebuild?

I would consider eliminating such a vulnerability a requirement.

@mohalone911
Copy link
Author

@djabraham , no it will not require a rebuild , they should be able to access the EKS cluster as long as they know the ARN of the User/Role that created the cluster and use the same User/Role ... IAM Role ARNs are strings and you can delete and recreate the same IAM Role/User repeatedly. Moreover, the best practice is to use Roles, rather than IAM User accounts to create and manage clusters.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2021

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the stale label Apr 4, 2021
@github-actions
Copy link
Contributor

This issue was closed because it has been stalled for 5 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request priority/backlog Not staffed at the moment. Help wanted. stale
Projects
None yet
Development

No branches or pull requests

6 participants