[Task] Move functionality out of nodegroup and nodegroup_service #5475
Labels
area/tech-debt
Leftover improvements in code, testing and building
good first issue
Good for newcomers
priority/important-longterm
Important over the long term, but may not be currently staffed and/or may require multiple releases
Description
This ticket to refactor functionality as suggested below and original ticket here
nodegroup.go
Methods for validating that managed nodegroup configurations are supported by the EKS versions. Seems reasonable & EKS related ✔️
Also contains a random stack-related func that should not be here ❎
nodegroup_service.go
Methods for translating managed nodegroup configuration into real information, e.g. taking
instaceSelector
fields and expanding them, resolving AMIs for whenAMIFamily
is specified etc. All of this code seems to apply to managed and unmanaged nodegroup, which means its not necessarily EKS specific knowledge. Consider moving ❎ , but it might also be okay to leave here ✔️ 🤷Also contains some stray validation logic that should/code be in
nodegroup.go
The text was updated successfully, but these errors were encountered: