Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Move functionality out of fargate.go and logging_retryer.go #5484

Closed
Himangini opened this issue Jul 4, 2022 · 0 comments
Closed
Labels
area/tech-debt Leftover improvements in code, testing and building good first issue Good for newcomers priority/important-longterm Important over the long term, but may not be currently staffed and/or may require multiple releases

Comments

@Himangini
Copy link
Collaborator

Description

This ticket is to refactor the functionality mentioned below and here

fargate.go

Contains funcs for managing fargate. Definitely doesn't belong here ❎

func (fpt *fargateProfilesTask) Describe() string
func (fpt *fargateProfilesTask) Do(errCh chan error) error
func DoCreateFargateProfiles(config *api.ClusterConfig, fargateClient FargateClient) error
func ScheduleCoreDNSOnFargateIfRelevant(config *api.ClusterConfig, ctl *ClusterProvider, clientSet kubernetes.Interface) error

logging_retryer.go

Code for implementing our logging for the aws-sdk-go session. This should be moved along with the AWS API code changes.

@Himangini Himangini added the area/tech-debt Leftover improvements in code, testing and building label Jul 4, 2022
@Himangini Himangini added priority/important-longterm Important over the long term, but may not be currently staffed and/or may require multiple releases good first issue Good for newcomers labels Jul 22, 2022
@Himangini Himangini closed this as not planned Won't fix, can't repro, duplicate, stale Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tech-debt Leftover improvements in code, testing and building good first issue Good for newcomers priority/important-longterm Important over the long term, but may not be currently staffed and/or may require multiple releases
Projects
None yet
Development

No branches or pull requests

1 participant