Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

urllib3 v2.0 compatibility #1816

Closed
basepi opened this issue Apr 28, 2023 · 2 comments · Fixed by #1822
Closed

urllib3 v2.0 compatibility #1816

basepi opened this issue Apr 28, 2023 · 2 comments · Fixed by #1822
Assignees
Labels
agent-python bug upstream Issue caused by an upstream package
Milestone

Comments

@basepi
Copy link
Contributor

basepi commented Apr 28, 2023

urllib3 v2.0 came out during PyConUS 2023 and is resulting in hanging tests on windows, and test failures on Linux. We need to update our code/tests to ensure compatibility for this new version.

@basepi basepi added bug upstream Issue caused by an upstream package labels Apr 28, 2023
@basepi basepi added this to the 8.9 milestone Apr 28, 2023
@basepi basepi self-assigned this Apr 28, 2023
@pquentin
Copy link
Member

Hello fellow Elasticians 👋

We just released urllib3 2.0.1 that includes urllib3/urllib3#2992. We have extensive tests for cert pinning, but Tornado (our test server) can accept multiple connections at a time unlike pytest-localserver. So we did not see the resource leak that caused the deadlock in your case, sorry about that.

Would you mind giving 2.0.1 a try?

@basepi
Copy link
Contributor Author

basepi commented May 1, 2023

@pquentin worked wonderfully. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-python bug upstream Issue caused by an upstream package
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants