Skip to content
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.

Slack notification for pipelines: the link to the APM traces should be customizable #1247

Closed
mdelapenya opened this issue Aug 24, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@mdelapenya
Copy link
Contributor

In the use case of the e2e-testing framework, apart from the APM traces for the CI itself, we contribute APM traces for the tests themselves.

As a consumer of the slack notification, I'd like to be able to follow two APM links: one for the CI one for the tests, as they now live in two separated clusters (which makes me think if we should send the test traces to the same ES cluster)

@mdelapenya mdelapenya added the enhancement New feature or request label Aug 24, 2021
@v1v
Copy link
Member

v1v commented Aug 24, 2021

There are two different approaches here but in a nutshell, the e2e-testing might need to use the env variables:

  • OTEL_EXPORTER_OTLP_ENDPOINT
  • OTEL_EXPORTER_OTLP_HEADERS

if there are set.

Those env variables can be potentially exposed implicitly by the Jenkins OTEL plugin itself (see jenkinsci/opentelemetry-plugin@021085f) or the shared library could provide them (see https://github.com/elastic/apm-pipeline-library/blob/master/vars/withOtelEnv.txt and #1234 ), for the latter it's required to change the pipeline to use the step withOtelEnv

In any case, it's required to change the e2e-testing accordingly to consume those env variables if they are set.

Do you think that could be sufficient?

@mdelapenya
Copy link
Contributor Author

I think #1250 will resolve this question. Closing!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants