Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apm-server keystore create is too eager to overwrite #2029

Closed
axw opened this issue Mar 20, 2019 · 1 comment
Closed

apm-server keystore create is too eager to overwrite #2029

axw opened this issue Mar 20, 2019 · 1 comment
Assignees
@jalvz
Labels
discuss

Comments

@axw
Copy link
Member

axw commented Mar 20, 2019 

$ apm-server.exe keystore create
A keystore already exists, Overwrite? [Y/n]: 
Created apm-server keystore

If I were to accidentally hit enter, then my keystore would be blown away. I think for this type of destructive operation, the default should be N.
@axw axw added the discuss label Mar 20, 2019
@jalvz jalvz mentioned this issue Mar 20, 2019
Merged
@jalvz
Copy link
Contributor

jalvz commented Mar 25, 2019

fixes in #1982

@jalvz jalvz closed this as completed Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jalvz jalvz

Labels
discuss
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@graphaelli @axw @jalvz @alvarolobato