Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve efficiency on metricsets in aws module GetMetricData call #11820

Closed
kaiyan-sheng opened this issue Apr 15, 2019 · 0 comments · Fixed by #11882
Closed

Improve efficiency on metricsets in aws module GetMetricData call #11820

kaiyan-sheng opened this issue Apr 15, 2019 · 0 comments · Fixed by #11882
Assignees
@kaiyan-sheng
Labels
Metricbeat Metricbeat Team:Integrations Label for the Integrations team

Comments

@kaiyan-sheng
Copy link
Contributor

kaiyan-sheng commented Apr 15, 2019 •
edited
Loading

In current ec2 metricset code, we are constructing metricDataQueries per region per instance for GetMetricData cloudwatch api call. Because we have some metadata from DescribeInstances api call for each instance to add into each event. It will be more efficient/cheaper to improve ec2 metricset to construct metricDataQueries per region but not per instance.
@kaiyan-sheng kaiyan-sheng self-assigned this Apr 15, 2019
@kaiyan-sheng kaiyan-sheng added Team:Integrations Label for the Integrations team Metricbeat Metricbeat labels Apr 15, 2019
@kaiyan-sheng kaiyan-sheng mentioned this issue Apr 15, 2019
Closed
7 tasks
@kaiyan-sheng kaiyan-sheng mentioned this issue Apr 19, 2019
Merged
@kaiyan-sheng kaiyan-sheng changed the title Improve efficiency on ec2 metricset GetMetricData call Improve efficiency on metricsets in aws module GetMetricData call Apr 25, 2019
@kaiyan-sheng kaiyan-sheng changed the title Improve efficiency on metricsets in aws module GetMetricData call Improve efficiency on metricsets in aws module GetMetricData call Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaiyan-sheng kaiyan-sheng

Labels
Metricbeat Metricbeat Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Call GetMetricData api per region instead of per instance
2 participants
@kaiyan-sheng @alvarolobato