Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for setting the document ID #14363

Closed
3 tasks done
urso opened this issue Nov 1, 2019 · 5 comments
Closed
3 tasks done

Support for setting the document ID #14363

urso opened this issue Nov 1, 2019 · 5 comments
Assignees
Labels
libbeat meta release-highlight Team:Integrations Label for the Integrations team test-plan Add this PR to be manual test plan test-plan-ok This PR passed manual testing v7.6.0

Comments

@urso
Copy link

urso commented Nov 1, 2019

For helping users to reduce duplicates in Elasticsearch, Beats should have some opt-in support to configure the document ID. If the field @metadata.id is set, Beats will already use said ID as document ID. But this feature is still well hidden, because we currently have no support for setting this field.

If the document ID is set, Beats will publish using the op_type create.

@urso
Copy link
Author

urso commented Dec 11, 2019

@ycombinator Can we close this issue?

@ycombinator
Copy link
Contributor

Yep! Resolved via #5844, #14205, and #14524.

@zube zube bot added [zube]: Done and removed [zube]: Meta labels Dec 11, 2019
@urso urso added test-plan Add this PR to be manual test plan test-plan-regression Manually testing this PR found a regression labels Jan 27, 2020
@urso
Copy link
Author

urso commented Jan 27, 2020

Testing:
While testing I found that we are missing support for setting the document ID via the json_decode_fields processor. The processor is used when JSON documents/events are embedded as strings. Fix is available in #15859

@mdelapenya
Copy link
Contributor

mdelapenya commented Jan 29, 2020

Hi! 👋 Does this issue need to be added to the v7.6.0 test plan? Then I'd see convenient to add that label. @andresrc wdyt?

Thanks!

@urso urso added v7.6.0 test-plan-ok This PR passed manual testing and removed test-plan-regression Manually testing this PR found a regression labels Jan 29, 2020
@urso
Copy link
Author

urso commented Jan 29, 2020

Added missing v7.6.0 label. All found issues have been resolved in 7.6.

@andresrc andresrc added the Team:Integrations Label for the Integrations team label Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libbeat meta release-highlight Team:Integrations Label for the Integrations team test-plan Add this PR to be manual test plan test-plan-ok This PR passed manual testing v7.6.0
Projects
None yet
Development

No branches or pull requests

4 participants