Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonize redis intput/module/output settings #16522

Open
urso opened this issue Feb 24, 2020 · 10 comments
Open

Harmonize redis intput/module/output settings #16522

urso opened this issue Feb 24, 2020 · 10 comments
Assignees
Labels
enhancement Team:Service-Integrations Label for the Service Integrations team

Comments

@urso
Copy link

urso commented Feb 24, 2020

With 7.7.0 we are introducing support for configuring the redis host via URLs in the output. In Beats we have a Filebeat redis logs input (collect logs, not event stream input), Metricbeat redis module, and the redis output. The different plugins should provide a similar set of settings and connection capabilites (x=present, -=missing):

settings output FB input MB module
redis:// URL x - x
rediss:// URL x - -
URL options - - x
URL db number - - x
ssl settings x - -
proxy x - -
proxy local resolver x - -
@urso urso added enhancement Team:Services (Deprecated) Label for the former Integrations-Services team labels Feb 24, 2020
@jsoriano
Copy link
Member

jsoriano commented Apr 9, 2020

Client library used in Metricbeat already supports rediss URLs and TLS settings (since gomodule/redigo#208), but we are using an older version 🙁 A good starting point could be to upgrade the library.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@wsucoug69
Copy link

I see the client library has been updated, any eta for the Metricbeat module to support ACLs and TLS settings for Redis?

@umeshauv
Copy link

Hi, Is this issue still open for MB ?

@jlind23 jlind23 added Team:Service-Integrations Label for the Service Integrations team and removed [zube]: Backlog Team:Integrations Label for the Integrations team Team:Services (Deprecated) Label for the former Integrations-Services team labels Mar 31, 2022
@botelastic
Copy link

botelastic bot commented Mar 31, 2023

Hi!
We just realized that we haven't looked into this issue in a while. We're sorry!

We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1.
Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Mar 31, 2023
@j771
Copy link

j771 commented Jul 5, 2023

TLS still not supported to redis module for metricbeat?
I tried on metricbeat 7.17.3 and I get timeout errors connecting to the redis.

@botelastic botelastic bot removed the Stalled label Jul 5, 2023
@wizardist
Copy link

@jsoriano that would also require using the URL dialer.

@jlind23 how fast would it take to upstream TLS support for this module should we decide to submit a patch?

@jlind23
Copy link
Collaborator

jlind23 commented Apr 3, 2024

@wizardist this is a bit out of my wheelhouse but @lalit-satapathy might be able to help as this is own by his team.

@shmsr
Copy link
Member

shmsr commented Jul 1, 2024

Support for SSL/ TLS was added for metricbeat's Redis module but not in the filebeat input.

See: #35240 (metricbeat TLS support)
See: #39412 (open issue to add filebeat input Redis TLS support)

We are planning to take this up in our upcoming sprints to add SSL/TLS support in the filebeat input.

cc: @lalit-satapathy @gpop63

@lalit-satapathy
Copy link
Contributor

Adding @gpop63 to enable the remaining one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Team:Service-Integrations Label for the Service Integrations team
Projects
None yet
Development

No branches or pull requests