Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elastic Agent] Make log level reloadable #20756

Closed
michalpristas opened this issue Aug 24, 2020 · 11 comments
Closed

[Elastic Agent] Make log level reloadable #20756

michalpristas opened this issue Aug 24, 2020 · 11 comments
Assignees

Comments

@michalpristas
Copy link
Contributor

The goal is to have the option to change behavior of the logger on the fly (mainly log level)
currently there is a need to restart an agent to have log level updated and propagated to sub-processes.

The idea is to get advantage of re-exec functionality to respawn an agent with correct log level which will restart beats so they pick up correct configuration as well.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@ruflin
Copy link
Contributor

ruflin commented Aug 24, 2020

Related Beat issue can be found here: #18081

@ph ph added the v7.11.0 label Oct 14, 2020
@ph
Copy link
Contributor

ph commented Oct 14, 2020

@blakerouse @michalpristas

Can you come up with a proposal on how we could solve that use case?
Lets make sure we involve @ferullo on that case, they are currently planning to support it.

fyi @ruflin

@ph ph added discuss Issue needs further discussion. and removed discuss Issue needs further discussion. labels Oct 14, 2020
@michalpristas
Copy link
Contributor Author

so far i adressed use case of log level reload initiated by fleet action.
do we want to allow reload in standalone mode? atm if user changes any setting (except for monitoring) user is responsible for restarting an agent. product wise, which part do we want to go with logging. it would mean automatic restart/reexec anyways

cc @ph @ruflin

@blakerouse
Copy link
Contributor

I think it would be acceptable to require them to call elastic-agent restart which we already have.

@ruflin
Copy link
Contributor

ruflin commented Nov 23, 2020

I'm good with having a manual action in standalone.

@ph
Copy link
Contributor

ph commented Nov 23, 2020

++ on having it manual on standalone.

Thanks @michalpristas this will be nice.

@michalpristas
Copy link
Contributor Author

discussed with @ferullo agent will notify endpoint about log level change as part of the config under fleet section.

@ph
Copy link
Contributor

ph commented Nov 25, 2020

@michalpristas What about the non-matching log level, like notice?

@ferullo
Copy link

ferullo commented Nov 25, 2020

It's ok if the only Endpoint log levels that can configured via agent are error, warning, info and debug.

@michalpristas
Copy link
Contributor Author

@ph can we close this? cherry pick in and endpoint is reading configuration passed in

@ph ph closed this as completed Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants