Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default value replace_fields to false in add_host_metadata processor #21774

Closed
kaiyan-sheng opened this issue Oct 13, 2020 · 2 comments
Closed
Labels
breaking change Stalled Team:Platforms Label for the Integrations - Platforms team

Comments

@kaiyan-sheng
Copy link
Contributor

We added this new config parameter replace_fields into add_host_metadata processor in #20490 to make sure we have the ability to overwrite host.* fields or not. Right now, the default for replace_fields is true, which means add_host_metadata will overwrite host fields.

With recently added new fields for host inventory schema work and once these fields start getting used by UI, we need to make the breaking change to switch the default replace_fields value to false. This way, the new added host.* fields will not be overwritten.

@kaiyan-sheng kaiyan-sheng added breaking change Team:Platforms Label for the Integrations - Platforms team labels Oct 13, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic
Copy link

botelastic bot commented Jan 27, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@botelastic botelastic bot added the Stalled label Jan 27, 2022
@botelastic botelastic bot closed this as completed Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Stalled Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

No branches or pull requests

2 participants